Opened 10 years ago

Closed 10 years ago

#509 closed enhancement (fixed)

Select-current-sexpr fails if the sexpr is commented out

Reported by: rongarret Owned by:
Priority: minor Milestone:
Component: IDE Version: 1.3
Keywords: Cc:

Description

Double-clicking on the close-paren of a sexpr fails to select that sexpr if the sexpr has been commented out with a preceding semicolon.

Change History (3)

comment:1 Changed 10 years ago by gb

Whether this is good or bad is debatable, but it's certainly intentional; S-expression based navigation doesn't work inside strings or ;-style comments.

comment:2 Changed 10 years ago by rongarret

  • Priority changed from normal to minor
  • Type changed from defect to enhancement

Well, I'll argue it's bad, for the following reasons:

  1. I often put test forms in comments that I don't want executed when the file loads, but which I like to be able to execute interactively during debugging.
  1. Fred worked this way. :-)

But if it's intentional I'll change it from defect to enhancement

comment:3 Changed 10 years ago by gz

  • Resolution set to fixed
  • Status changed from new to closed

(In [13186]) A bunch of Hemlock Lisp mode changes:

  • Add parsing support for |symbol quoting| and #| nested comments |#. This fixes bug 421.
  • Change comment syntax coloring color from light gray to brown. Use it to color #| |# blocks as well as ;;; comments. Do NOT use it to color escaped symbol constituents.
  • Add support for moving over lisp forms without pre-parsing info, for use when pre-parsing info is not available. Use this to allow navigation (i.e. c-m-f et. al.) inside strings and comment (seems like there would have been a ticket for this but I didn't find one).
  • Make meta-. work inside comments
  • Extend double-click selection to work inside comments/strings, ditto for Enter. This fixes bug 503 and bug 509.
  • Fix a couple bugs in pre-parsing of lines with escape at end. This was the underlying cause of bug 444, so this fixes bug 444.
  • Make triple-click select symbols vs. words for double-click. This addresses bug 496.
  • parse-over-block: fix the constant reparsing of the first line.
  • set-temporary-character-attributes: do not force reparsing, as this is called a lot.
  • fix macroexpand commands to act in-lisp context
  • Init hemlock syntax attributes from ccl::%standard-readtable%
  • Replace Editor Compile Defun and Editor Evaluate Defun with Editor Execute Defun, and replace Editor Compile Region and Editor Evaluate Region with Editor Execute Expression.
  • Make the form selected by double-clicking be the same as the form used for execution and macroexpansion commands, and make it be more general. This fixes bug 577 and bug 65 and bug 188.
  • some other changes that I no longer remember because I had this checked out for way too long...
Note: See TracTickets for help on using tickets.