Opened 12 years ago

Closed 10 years ago

#49 closed defect (fixed)

meta-dot for structure accessors should work

Reported by: jaj Owned by: gb
Priority: minor Milestone:
Component: IDE Version:
Keywords: Cc:

Description

Currently, meta-dot on a structure accessor quietly fails. It should go to the defstruct, and ideally the cursor should be at the line that defines the slot.

Change History (2)

comment:1 Changed 12 years ago by gb

  • Owner changed from jaj to gb
  • Priority changed from major to minor
  • Status changed from new to assigned

This (and the similar case of slot accessors) used to "work" in MCL because MCL fell back to a simple text search and (often) the first occurrence of the accessor name anywhere in the file was the slot definition form.

The addition of the MOP broke some of this as well (in MCL, too); a DEFCLASS form that contained accessor definitions expanded into a bunch of DEFMETHOD forms, each of which did a RECORD-SOURCE-FILE. M-. wouldn't find the DEFMETHOD in the file, but it at least knew what file to do a simple-search-and-maybe-get-lucky in.

OpenMCL's meta-. should probably fall back to a simple search as a last resort, but it'd also be possible to extend RECORD-SOURCE-FILE and M-. to deal with accessors (e.g., remembering the parent DEFCLASS/DEFSTRUCT form and trying to find the accessor name inside that form's slot definitions.)

comment:2 Changed 10 years ago by gz

  • Resolution set to fixed
  • Status changed from assigned to closed

This was all fixed by source location recording. (it doesn't go to the specific accessor within the defstruct/defclass, so perhaps a separate ticket should be opened for that).

Note: See TracTickets for help on using tickets.