Opened 12 years ago

Closed 12 years ago

#27 closed defect (fixed)

Incremental Search should highlight found text

Reported by: alms Owned by: gb
Priority: major Milestone:
Component: IDE Version:
Keywords: Cc:

Description

Incremental search (control-s and control-r) currently moves the point to the found text, but it doesn't highlight the found text. It would be nice if it highlighted the found text. For bonus points, highlight all the occurrences of found text in the window (using a distinct highlight for the occurrence where the point is).

I'm calling this an enhancement, but it might be considered a defect, at least the first part.

Change History (3)

comment:1 Changed 12 years ago by gb

  • Status changed from new to assigned

I think that C-s should probably do the same kind of highlighting that Cmd-F does (select the single instance of the found text, do whatever the OS does to highlight that selection, including the transient highlighting found on recent OS releases.)

comment:2 Changed 12 years ago by alms

  • Priority changed from minor to major
  • Type changed from enhancement to defect

Currently control-s (forward incremental search) highlights the found text correctly (although it doesn't use the temporary flashing orange box that command-f uses). However, control-r (reverse incremental search) doesn't show the selection correctly. If you initiate an incremental search with control-r, it doesn't show any selection. If you switch from control-s to control-r, it shows you a thoroughly bogus selection.

Because of this bogus behavior of control-r I've switched this ticket from "enhancement" to "defect".

For a further enhancement, we could consider emulating the highlighting approach used by Safari 3.0: it highlights the current found text in orange, and it highlights other visible occurrences of the search string in white. (It does this by graying out the whole page other than the visible occurrences of the search string. I don't think that would be good for us to do. But it is nice showing all the visible occurrences with some subtle highlighting.)

comment:3 Changed 12 years ago by jaj@…

  • Resolution set to fixed
  • Status changed from assigned to closed

I'm closing this ticket since I can't find anything wrong with the current behaviour. I'll open a new ticket for the enhancement request at the end of the last comment.

Note: See TracTickets for help on using tickets.