Custom Query (1030 matches)

Reported by Eric Marsden on bug-openmcl:

When a method combination has been defined in the running image, ClozureCL compilation fails in libs/method-combination.lisp :

,----
| ;Compiling "/usr/local/src/clozure/ccl/lib/method-combination.lisp"...
| ;Loading #P"/usr/local/src/clozure/ccl/bin/method-combination.lx64fsl"...
| > Error: value #<Anonymous Function #x30004090A0FF> is not of the expected type LIST.
| > While executing: LIST-LENGTH, in process listener(1).
| > Type :POP to abort, :R for a list of available restarts.
| > Type :? for other options.
| 1 > :b
| *(7FF537A2D1A0) : 0 (LIST-LENGTH ((#:ARGS . #:GF) . #<Anonymous Function #x30004090A0FF>)) 109
|  (7FF537A2D208) : 1 (PLISTP ((#:ARGS . #:GF) . #<Anonymous Function #x30004090A0FF>)) 61
|  (7FF537A2D228) : 2 (PL-SEARCH ((#:ARGS . #:GF) . #<Anonymous Function #x30004090A0FF>) :OPERATOR) 45
|  (7FF537A2D248) : 3 (GETF ((#:ARGS . #:GF) . #<Anonymous Function #x30004090A0FF>) :OPERATOR NIL) 69
|  (7FF537A2D270) : 4 (FUNCALL #'#<(:INTERNAL %DEFINE-METHOD-COMBINATION-EVALUATOR)> ASDF:STANDARD-ASDF-METHOD-COMBINATION #(LONG-METHOD-COMBINATION (# . #) #<POPULATION #x30004090A0BD> #<POPULATION #x30004090A09D>)) 109
|  (7FF537A2D2A0) : 5 (MAPHASH 2 #<HASH-TABLE :TEST EQ size 10/60 #x3000407A539D>) 421
|  (7FF537A2D308) : 6 (%DEFINE-METHOD-COMBINATION-EVALUATOR AND #<Anonymous Function #x30004170A52F>) 485
|  (7FF537A2D328) : 7 (FUNCALL #'#<Anonymous Function #x30004170A77F>) 477
|  (7FF537A2D348) : 8 (FUNCALL #'#<$FASL-LFUNCALL> #<FASLSTATE #x7FF53903CE6D>) 77
`----

I ran into this because I load ASDF from my init file. Compilation works fine without ASDF (or other use of DEFINE-METHOD-COMBINATION) loaded; until a few days ago it was possible to build ClozureCL with ASDF loaded.

The following function doesn't work properly on MacOS/64bit (32bit is ok, I didn't test other platforms).

(defun foo (x)
  (if (vectorp x)
      x
      (foo (vector x))))

Welcome to Clozure Common Lisp Version 1.9-r15883M  (DarwinX8664)!
? (defun foo (x) (if (vectorp x) x (foo (vector x))))
FOO
? (foo 'test)
#(#(#(#(#(#(#(................#(#(#(#(#(#(#(
> Error: Stack overflow on temp stack.

Welcome to Clozure Common Lisp Version 1.9-r15788M  (DarwinX8632)!
? (defun foo (x) (if (vectorp x) x (foo (vector x))))
FOO
? (foo 'test)
#(TEST)

with-hash-table-iterator in file macros.lisp results in what appears to be unnecessary consing.

Consing is reduced by adding ,state to the list of dynamic-extent declarations, as shown below.

(defmacro with-hash-table-iterator ((mname hash-table) &body body)

"WITH-HASH-TABLE-ITERATOR ((function hash-table) &body body)

provides a method of manually looping over the elements of a hash-table. FUNCTION is bound to a generator-macro that, within the scope of the invocation, returns one or three values. The first value tells whether any objects remain in the hash table. When the first value is non-NIL, the second and third values are the key and the value of the next object."

(let* ((hash (gensym))

(keys (gensym)) (values (gensym)) (count (gensym)) (state (gensym)))

`(let* ((,hash ,hash-table)

(,count (hash-table-count ,hash)) (,keys (make-array ,count)) (,values (make-array ,count)) (,state (vector ,hash 0 ,keys ,values (enumerate-hash-keys-and-values ,hash ,keys ,values))))

(declare (dynamic-extent ,keys ,values ,state)

(fixnum ,count))

(macrolet ((,mname () `(next-hash-table-iteration-1 ,',state)))

,@body))))