Custom Query (1030 matches)

I've discovered multiple problems in ARM FFI while trying to run CFFI test suite.

1. There was a stray apostrophe in lib/ffi-linuxarm.lisp in arm-linux::generate-callback-bindings which caused problems with compilation. Fixed in the patch.

2. There was an error in s8->fixnum vinsn (val / result confusion, shift in the wrong direction). Attached charfail.lisp demonstrates the problem. Fixed in the patch.

3. There was a problem in mem-set-c-single-float / mem-set-single-float, val/src confusion that didn't seem to affect anything most of the time by pure accident plus bad index reference in mem-set-single-float. This is demonstrated by the second assert in attached floatfail.lisp. Fixed in the patch.

4. There is still a problem with mem-set-c-double-float, mem-set-double-float, get-double, get-double? and maybe other functions. Besides ignoring val and using src instead in mem-set(-c)-double-float, there's a more serious problem that I was unable to fix.

Namely, these functions use explicit register specifications for their temps that are used for strd/ldrd instructions that need consective registers. This seems to break register handling somehow, as the following can be observed at the end of disassembly of my-mem-set-double-float in attached floatfail.lisp:

  (ldrd imm0 (:@ arg_z (:$ 2)))
  (fmdrr d0 imm0 imm1)
  (add nargs imm0 imm1)
  (fmrrd imm0 imm1 d0)
  (strd imm0 (:@ nargs (:$ 0)))
  (ldmia (:! sp) (imm0 vsp fn pc))

Here we see imm0 and imm1 getting destroyed by get-double vinsn and later being used to construct address for the following strd as if nothing happened. This leads to memory fault.

The possible workaround is not using strd/ldrd at all but perhaps it's also possible to fix temp handling, but I don't have time to do it myself right now.

Looking at init-cocoa-application it would seem that the intent there is to permit the use of a CCLDelegateClass attribute in the Info.plist as a way to set a different Application delegate class. This would be very convenient. Unfortunately if you do that, the delegate is then RESET in start-cocoa-application (after the call to init-cocoa-application). Although start-cocoa-application has a parameter that allows overriding of the default application delegate, using it would require also providing a new top-level function, which isn't as convenient. The setting of the app delegate in start-cocoa-application should be conditionalized by the non-existence of a current app delegate.

I suggest changing the code:

(when application-proxy-class-name ...)

in start-cocoa-application to :

(when (and application-proxy-class-name

(%null-ptr-p (#/delegate *NSApp*))) ...)

This would permit setting an application delegate either by using the Info.plist setting as described above or by specifying an application delegate in the main nib file that is set when that is loaded. Although I could do a bunch of work to work around this, I hope this change can be made fairly quickly.

I don't know if I built something wrong, because I don't remember this before, but maybe I just hadn't tried before: resizing behavior is broken in some bizarre way. E.g. clicking on a window border causes the window to jump to a different size, can't make it any smaller by dragging.