Changeset 9733 for release

Timestamp:

Jun 11, 2008, 8:53:55 AM (11 years ago)

Author:

gb

Message:

vinsns ONE-OPT-SUPPLIED-P, TWO-OPT-SUPPLIED-P, OPT-SUPPLIED-P:
conditionally move (@ (+ t-offset symbol.vcell) nil), not (@ t-offset nil).
The latter does a misaligned reference of the word that the tagged pointer
to T, which (by sheer luck) is usually a random-looking fixnum. We really
want to (conditionally) move T's value cell to the destination here.

Gail's fix to CHECK-MISC-BOUND, from trunk.

File:

• release/1.2/source/compiler/X86/X8664/x8664-vinsns.lisp (modified) (4 diffs)

release/1.2/source/compiler/X86/X8664/x8664-vinsns.lisp

@@ -794 +794 @@
   (shlq (:$ub x8664::fixnumshift) (:%q temp))
   (rcmpq (:%q idx) (:%q temp))
-  (jge :bad)
+  (jae :bad)
 
   (:anchored-uuo-section :resume)
@@ -3232 +3232 @@
   (rcmpl (:%l imm) (:%l nargs))
   (movl (:%l x8664::arg_y) (:%l x8664::arg_z))
-  (cmovll (:@ x8664::t-offset (:%l x8664::arg_y)) (:%l  x8664::arg_z))
+  (cmovll (:@ (+ x8664::t-offset x8664::symbol.vcell) (:%l x8664::arg_y)) (:%l  x8664::arg_z))
   (addl (:$b x8664::node-size) (:%l imm))
   (rcmpl (:%l imm) (:$l (:apply ash num-opt x8664::fixnumshift)))
@@ -3243 +3243 @@
   (testl (:%l x8664::nargs) (:%l x8664::nargs))
   (movl (:$l x8664::nil-value) (:%l temp))
-  (cmovnel (:@ x8664::t-offset (:%l temp)) (:%l temp))
+  (cmovnel (:@ (+ x8664::t-offset x8664::symbol.vcell) (:%l temp)) (:%l temp))
   (pushq (:%q temp)))
 
@@ -3253 +3253 @@
   (movl (:$l x8664::nil-value) (:%l temp0))
   (movl (:%l temp0) (:%l temp1))
-  (cmovael (:@ x8664::t-offset (:%l temp0)) (:%l temp0))
-  (cmoval (:@ x8664::t-offset (:%l temp1)) (:%l temp1))
+  (cmovael (:@ (+ x8664::t-offset x8664::symbol.vcell) (:%l temp0)) (:%l temp0))
+  (cmoval (:@ (+ x8664::t-offset x8664::symbol.vcell) (:%l temp1)) (:%l temp1))
   (pushq (:%q temp0))
   (pushq (:%q temp1)))