Changeset 6193

Timestamp:

Apr 7, 2007, 8:58:08 PM (18 years ago)

Author:

Gary Byers

Message:

%TCR-INTERRUPT: don't signal if interrupt is obviously pending.

File:

• trunk/ccl/level-1/l1-lisp-threads.lisp (modified) (1 diff)

trunk/ccl/level-1/l1-lisp-threads.lisp

@@ -349 +349 @@
 
 (defun %tcr-interrupt (tcr)
-  (with-macptrs (tcrp)
-    (%setf-macptr-to-object tcrp tcr)
-    (ff-call
-     (%kernel-import target::kernel-import-raise-thread-interrupt)
-     :address tcrp
-     :signed-fullword)))
+  ;; The other thread's interrupt-pending flag might get cleared
+  ;; right after we look and see it set, but since this is called
+  ;; with the lock on the thread's interrupt queue held, the
+  ;; pending interrupt won't have been taken yet.
+  ;; When a thread dies, it should try to clear its interrupt-pending
+  ;; flag.
+  (or (not (eql 0 (%fixnum-ref tcr target::tcr.interrupt-pending)))
+      (with-macptrs (tcrp)
+        (%setf-macptr-to-object tcrp tcr)
+        (ff-call
+         (%kernel-import target::kernel-import-raise-thread-interrupt)
+         :address tcrp
+         :signed-fullword))))
+