Changeset 5569

Timestamp:

Dec 3, 2006, 1:21:37 AM (18 years ago)

Author:

Gary Byers

Message:

CHECK-MISC-BOUNDS: shift the header word right (after clearing its low
byte) and compare the index to that. (Shifting the index left - d'oh -
obviously fails for indices of large magnitude.)

File:

• trunk/ccl/compiler/X86/X8664/x8664-vinsns.lisp (modified) (1 diff)

trunk/ccl/compiler/X86/X8664/x8664-vinsns.lisp

@@ -680 +680 @@
                                        (v :lisp))
                                       ((temp :u64)))
-  (movq (:%q idx) (:%q temp))
-  (shlq (:$ub (- x8664::num-subtag-bits x8664::fixnumshift)) (:%q temp))
-  (decb (:%b temp))
-  (rcmpq (:%q temp) (:@ x8664::misc-header-offset (:%q v)))
+  (movq (:@ x8664::misc-header-offset (:%q v)) (:%q temp))
+  (xorb (:%b temp) (:%b temp))
+  (shrq (:$ub (- x8664::num-subtag-bits x8664::fixnumshift)) (:%q temp))
+  (rcmpq (:%q idx) (:%q temp))
   (jb.pt :ok)
   (uuo-error-vector-bounds (:%q idx) (:%q v))