Changeset 5224

Timestamp:

Sep 20, 2006, 3:14:40 AM (18 years ago)

Author:

Gary Byers

Message:

vinsns for signed/unsigned byte 8,16,32,64. Tighten up some signed-byte boxing.

File:

• trunk/ccl/compiler/X86/X8664/x8664-vinsns.lisp (modified) (8 diffs)

trunk/ccl/compiler/X86/X8664/x8664-vinsns.lisp

@@ -2559 +2559 @@
   (movq (:%q object) (:%q tag))
   (shlq (:$ub (- x8664::nbits-in-word (+ 8 x8664::fixnumshift))) (:%q tag))
-  (sarq (:$ub (- x8664::nbits-in-word (+ 8 x8664::fixnumshift))) (:%q tag))
+  (sarq (:$ub (- x8664::nbits-in-word 8)) (:%q tag))
+  (shlq (:$ub x8664::fixnumshift) (:%q tag))
   (cmpq (:%q object) (:%q tag))
-  (jne.pn :bad)
-  (testb (:$b x8664::fixnummask) (:%b object))
-  (je.pt :bad)
+  (je.pt :ok)
   :bad
   (uuo-error-reg-not-type (:%q object) (:$ub arch::error-object-not-signed-byte-8))
@@ -2573 +2572 @@
                                 ((tag :u32)))
   :again
-  (movl (:$l (lognot (ash #xff x8664::fixnumshift))) (:%l tag))
+  (movq (:$l (lognot (ash #xff x8664::fixnumshift))) (:%q tag))
   (andq (:% object) (:% tag))
   (je.pt :ok)
@@ -2586 +2585 @@
   (movq (:%q object) (:%q tag))
   (shlq (:$ub (- x8664::nbits-in-word (+ 16 x8664::fixnumshift))) (:%q tag))
-  (sarq (:$ub (- x8664::nbits-in-word (+ 16 x8664::fixnumshift))) (:%q tag))
+  (sarq (:$ub (- x8664::nbits-in-word 16)) (:%q tag))
+  (shlq (:$ub x8664::fixnumshift) (:%q tag))
   (cmpq (:%q object) (:%q tag))
-  (jne.pn :bad)
-  (testb (:$b x8664::fixnummask) (:%b object))
-  (je.pt :bad)
+  (je.pt :ok)
   :bad
   (uuo-error-reg-not-type (:%q object) (:$ub arch::error-object-not-signed-byte-16))
@@ -2600 +2598 @@
                                 ((tag :u32)))
   :again
-  (movl (:$l (lognot (ash #xffff x8664::fixnumshift))) (:%l tag))
+  (movq (:$l (lognot (ash #xffff x8664::fixnumshift))) (:%q tag))
   (andq (:% object) (:% tag))
   (je.pt :ok)
@@ -2613 +2611 @@
   (movq (:%q object) (:%q tag))
   (shlq (:$ub (- x8664::nbits-in-word (+ 32 x8664::fixnumshift))) (:%q tag))
-  (sarq (:$ub (- x8664::nbits-in-word (+ 32 x8664::fixnumshift))) (:%q tag))
+  (sarq (:$ub (- x8664::nbits-in-word 32)) (:%q tag))
+  (shlq (:$ub x8664::fixnumshift) (:%q tag))
   (cmpq (:%q object) (:%q tag))
   (jne.pn :bad)
@@ -2651 +2650 @@
   :ok)
 
-(define-x8664-vinsn require-s64 (()
+(define-x8664-vinsn require-u64 (()
                                 ((object :lisp))
                                 ((tag :s64)))
@@ -2664 +2663 @@
   (je :two)
   (cmpq (:$l x8664::three-digit-bignum-header) (:@ x8664::misc-header-offset (:%q object)))
-  (je.pn :bad)
+  (jne.pn :bad)
   (cmpl (:$b 0) (:@ (+ x8664::misc-data-offset 8) (:%q object)))
   (je :ok)
@@ -2674 +2673 @@
   :ok-if-non-negative
   (testq (:%q tag) (:%q tag))
-  (jl :bad)
+  (js :bad)
   :ok)