Changeset 15380

Timestamp:

May 25, 2012, 4:52:43 AM (13 years ago)

Author:

Gary Byers

Message:

In various things that do vector reference/assignment, reject negative
constant indices. (Vinsns may not be consistent about whether constant
indices are signed or unsigned, and the error may not be intelligible
if constraints aren't met.)

File:

• trunk/source/compiler/X86/x862.lisp (modified) (3 diffs)

trunk/source/compiler/X86/x862.lisp

@@ -2014 +2014 @@
              (unscaled-idx nil)
              (src nil))
+        (when index-known-fixnum
+          (unless (>= index-known-fixnum 0)
+            (setq index-known-fixnum nil)))
         (if (or safe (not index-known-fixnum))
           (multiple-value-setq (src unscaled-idx)
@@ -2286 +2289 @@
            (src nil)
            (unscaled-idx nil))
+      (when (and index-known-fixnum (< index-known-fixnum 0))
+        (setq index-known-fixnum nil))
       (with-imm-target () (target :natural)
         (if (or safe (not index-known-fixnum))
@@ -2719 +2724 @@
            (needs-memoization (and is-node (x862-acode-needs-memoization value)))
            (index-known-fixnum (acode-fixnum-form-p index)))
+      (when (and index-known-fixnum (< index-known-fixnum 0))
+        (setq index-known-fixnum nil))
       (let* ((src (target-arch-case
                    (:x8632 ($ x8632::temp0))