Changeset 15142

Timestamp:

Dec 16, 2011, 3:43:44 PM (13 years ago)

Author:

Gary Byers

Message:

Back out of most of the changes in r15131, which inadvertently
included some experimental code.

Relative to r15130, this version of the file contains only
the following changes:

get_tcr(): on Win32, check the linear field of the presumed TCR
address, don't just return a (possibly uninitialized) address in
the TEB.

dequeue_tcr(): set tcr->linear to NULL on x8632, too.

File:

• trunk/source/lisp-kernel/thread_manager.c (modified) (5 diffs)

trunk/source/lisp-kernel/thread_manager.c

@@ -87 +87 @@
   /* What if the suspend count is > 1 at this point ?  I don't think
      that that matters, but I'm not sure */
-  pcontext->ContextFlags = CONTEXT_FULL;
+  pcontext->ContextFlags = CONTEXT_ALL;
   rc = GetThreadContext(hthread, pcontext);
   if (rc == 0) {
@@ -2020 +2020 @@
       return false;
     }
-    pcontext->ContextFlags = CONTEXT_FULL;
+    pcontext->ContextFlags = CONTEXT_ALL;
     rc = GetThreadContext(hthread, pcontext);
     if (rc == 0) {
@@ -2027 +2027 @@
     where = (pc)(xpPC(pcontext));
 
-    if ((where >= restore_windows_context_start) &&
-        (where < restore_windows_context_end) &&
-        (tcr->valence != TCR_STATE_LISP)) {
-      Bug(NULL, "Forgot about this case ...");
-    }
     if (tcr->valence == TCR_STATE_LISP) {
       if ((where >= restore_windows_context_start) &&
@@ -2066 +2061 @@
           ResumeThread(hthread);
           SEM_WAIT_FOREVER(TCR_AUX(tcr)->suspend);
-          pcontext = NULL;
+          SuspendThread(hthread);
+          /* The thread is either waiting for its resume semaphore to
+             be signaled or is about to wait.  Signal it now, while
+             the thread's suspended. */
+          SEM_RAISE(TCR_AUX(tcr)->resume);
+          pcontext->ContextFlags = CONTEXT_ALL;
+          GetThreadContext(hthread, pcontext);
         }
       }
@@ -2193 +2194 @@
     HANDLE hthread = (HANDLE)(TCR_AUX(tcr)->osid);
 
-
-    TCR_AUX(tcr)->suspend_context = NULL;
     if (context) {
-      if (tcr->valence == TCR_STATE_LISP) {
-        rc = SetThreadContext(hthread,context);
-        if (! rc) {
-          Bug(NULL,"SetThreadContext");
-          return false;
-        }
-      }
+      context->ContextFlags = CONTEXT_ALL;
+      TCR_AUX(tcr)->suspend_context = NULL;
+      SetThreadContext(hthread,context);
       rc = ResumeThread(hthread);
       if (rc == -1) {
-        Bug(NULL,"ResumeThread");
+        wperror("ResumeThread");
         return false;
       }
-      return true;
-    } else {
-      SEM_RAISE(TCR_AUX(tcr)->resume);
       return true;
     }