Changeset 15131

Timestamp:

Dec 11, 2011, 7:52:51 PM (13 years ago)

Author:

Gary Byers

Message:

get_tcr(): on Win32, check the linear field of the presumed TCR
address, don't just return a (possibly uninitialized) address in
the TEB.

dequeue_tcr(): set tcr->linear to NULL on x8632, too.

File:

• trunk/source/lisp-kernel/thread_manager.c (modified) (7 diffs)

trunk/source/lisp-kernel/thread_manager.c

@@ -87 +87 @@
   /* What if the suspend count is > 1 at this point ?  I don't think
      that that matters, but I'm not sure */
-  pcontext->ContextFlags = CONTEXT_ALL;
+  pcontext->ContextFlags = CONTEXT_FULL;
   rc = GetThreadContext(hthread, pcontext);
   if (rc == 0) {
@@ -788 +788 @@
   TCR_AUX(next)->prev = prev;
   TCR_AUX(tcr)->prev = TCR_AUX(tcr)->next = NULL;
-#ifdef X8664
+#ifdef X86
   tcr->linear = NULL;
 #endif
@@ -1900 +1900 @@
   TCR *current = current_tcr;
 #elif defined(WIN_32)
-  TCR *current = (TCR *)((char *)NtCurrentTeb() + TCR_BIAS);
+  TCR *current = ((TCR *)((char *)NtCurrentTeb() + TCR_BIAS))->linear;
 #else
   void *tsd = (void *)tsd_get(lisp_global(TCR_KEY));
@@ -2020 +2020 @@
       return false;
     }
-    pcontext->ContextFlags = CONTEXT_ALL;
+    pcontext->ContextFlags = CONTEXT_FULL;
     rc = GetThreadContext(hthread, pcontext);
     if (rc == 0) {
@@ -2027 +2027 @@
     where = (pc)(xpPC(pcontext));
 
+    if ((where >= restore_windows_context_start) &&
+        (where < restore_windows_context_end) &&
+        (tcr->valence != TCR_STATE_LISP)) {
+      Bug(NULL, "Forgot about this case ...");
+    }
     if (tcr->valence == TCR_STATE_LISP) {
       if ((where >= restore_windows_context_start) &&
@@ -2061 +2066 @@
           ResumeThread(hthread);
           SEM_WAIT_FOREVER(TCR_AUX(tcr)->suspend);
-          SuspendThread(hthread);
-          /* The thread is either waiting for its resume semaphore to
-             be signaled or is about to wait.  Signal it now, while
-             the thread's suspended. */
-          SEM_RAISE(TCR_AUX(tcr)->resume);
-          pcontext->ContextFlags = CONTEXT_ALL;
-          GetThreadContext(hthread, pcontext);
+          pcontext = NULL;
         }
       }
@@ -2194 +2193 @@
     HANDLE hthread = (HANDLE)(TCR_AUX(tcr)->osid);
 
+
+    TCR_AUX(tcr)->suspend_context = NULL;
     if (context) {
-      context->ContextFlags = CONTEXT_ALL;
-      TCR_AUX(tcr)->suspend_context = NULL;
-      SetThreadContext(hthread,context);
+      if (tcr->valence == TCR_STATE_LISP) {
+        rc = SetThreadContext(hthread,context);
+        if (! rc) {
+          Bug(NULL,"SetThreadContext");
+          return false;
+        }
+      }
       rc = ResumeThread(hthread);
       if (rc == -1) {
-        wperror("ResumeThread");
+        Bug(NULL,"ResumeThread");
         return false;
       }
+      return true;
+    } else {
+      SEM_RAISE(TCR_AUX(tcr)->resume);
       return true;
     }