Changeset 15121

Timestamp:

Dec 8, 2011, 10:23:53 AM (13 years ago)

Author:

Gary Byers

Message:

In ARM2-COPY-REGISTER: check more thoroughly that source and dest
FPR are the same (must be same mode). If copying from a single-float
to a double-float, observe *ARM2-FLOAT-SAFETY*.

In ARM2-%SINGLE-TO-DOUBLE, actually copy/coerce to a DOUBLE-FLOAT.
(This isn't the PPC, apparently.)

File:

• trunk/source/compiler/ARM/arm2.lisp (modified) (3 diffs)

trunk/source/compiler/ARM/arm2.lisp

@@ -3921 +3921 @@
                           (! single->node dest src))))))
                   (if (and src-fpr dest-fpr)
-                    (unless (eql dest-fpr src-fpr)
+                    (unless (and (eql dest-fpr src-fpr)
+                                 (eql dest-mode src-mode))
                       (case src-mode
                         (#.hard-reg-class-fpr-mode-single
@@ -3928 +3929 @@
                             (! single-to-single dest src))
                            (#.hard-reg-class-fpr-mode-double
-                            (! single-to-double dest src))))
+                            (if *arm2-float-safety*
+                              (! single-to-double-safe dest src)
+                              (! single-to-double dest src)))))
                         (#.hard-reg-class-fpr-mode-double
                          (case dest-mode
@@ -9155 +9158 @@
   (if (null vreg)
     (arm2-form seg vreg xfer arg)
-    (if (and (= (hard-regspec-class vreg) hard-reg-class-fpr)
-             (= (get-regspec-mode vreg) hard-reg-class-fpr-mode-double))
-      (progn
-        (arm2-one-untargeted-reg-form 
-         seg arg
-         (make-wired-lreg (hard-regspec-value vreg)
-                          :class hard-reg-class-fpr
-                          :mode hard-reg-class-fpr-mode-single))
-        (^))
-      (with-fp-target () (sreg :single-float)
-        (arm2-one-targeted-reg-form seg arg sreg)
-        (<- (set-regspec-mode sreg hard-reg-class-fpr-mode-double))
-        (^)))))
+    (with-fp-target () (sreg :single-float)
+      (setq sreg (arm2-one-untargeted-reg-form seg arg sreg))
+      (if (and (= (hard-regspec-class vreg) hard-reg-class-fpr)
+               (= (get-regspec-mode vreg) hard-reg-class-fpr-mode-double))
+        (<- sreg)
+        (with-fp-target (sreg) (dreg :double-float)
+          (arm2-copy-register seg dreg sreg)
+          (<- dreg)))
+      (^))))
 
 (defarm2 arm2-%symptr->symvector %symptr->symvector (seg vreg xfer arg)