Changeset 15004 for trunk/source/compiler/X86/X8664/x8664-vinsns.lisp

Timestamp:

Sep 29, 2011, 9:52:16 AM (9 years ago)

Author:

gb

Message:

Do some cases of CASE (and similar constructs) in constant time by
using a jump table in the x86 backends. This -seems- to do the right
things (wrt stack discipline, multiple values, etc.) in all cases that
I've tried (including a handful of things in CCL itself); it can
currently be disabled by setting CCL::*X862-GENERATE-CASEJUMP* to NIL
before compiling.

Get the x86 disassembler to recognize and display jump tables.
Persuade it to print the instruction address in a comment after the
instruction. (We're a ways from being able to re-assemble disassembled
code on x86 for several other reasons, but I think that this makes the
disassembly a little easier to read.)

File:

• trunk/source/compiler/X86/X8664/x8664-vinsns.lisp (modified) (3 diffs)

trunk/source/compiler/X86/X8664/x8664-vinsns.lisp

@@ -4632 +4632 @@
   (movq (:@ (:%q x8664::rbp)) (:%q x8664::rbp)))
 
-(define-x8664-vinsn (cjmp :branch) (((reg :lisp))
-                                    ((reg :lisp)
+(define-x8664-vinsn (cjmp :branch) (((reg :s64))
+                                    ((reg :s64)
                                      (minval :s32const)
                                      (maxval :u32const)
                                      (default :label))
-                                    ((temp :s32)
-                                    (rjmp :lisp)))
+                                    ((rjmp :lisp)))
   (testl (:$l x8664::fixnummask) (:%l reg))
   (jne default)
@@ -4645 +4644 @@
   (cmpq (:$l maxval) (:%q reg))
   (ja default)
-  (movl (:%l reg) (:%l temp))
-  (shrl (:%l temp))
-  (movl (:@ (:^ :jtab) (:%q x8664::fn) (:%q temp)) (:%l temp))
-  (leaq (:@ (:%q x8664::fn) (:%q temp)) (:%q rjmp))
+  (shrl (:%l reg))
+  (movl (:@ (:^ :jtab) (:%q x8664::fn) (:%q reg)) (:%l reg))
+  (leaq (:@ (:%q x8664::fn) (:%q reg)) (:%q rjmp))
   (jmp (:%q rjmp))
   (:uuo-section)
@@ -4654 +4652 @@
   (:long (:apply 1+ (:apply ash maxval (- x8664::fixnumshift))))
   :jtab)
-
-
+  
 
 (define-x8664-vinsn jtabentry (()