Changeset 14629

Timestamp:

Feb 1, 2011, 8:58:35 PM (14 years ago)

Author:

Gary Byers

Message:

x8664 'extract_subtag' macro: use movzbl to avoid a partial register
write. Change callers of that macro.
(Some cases of the old implementation showed up as costly in Shark
output.)

Location:

trunk/source/lisp-kernel

Files:

• x86-macros.s (modified) (1 diff)
• x86-spentry64.s (modified) (6 diffs)

trunk/source/lisp-kernel/x86-macros.s

@@ -543 +543 @@
 
 define(`extract_subtag',`
-        __(movb misc_subtag_offset($1),$2)
-')
+        __(movzbl misc_subtag_offset($1),$2_l)
+')
+
 
 ifdef(`X8632',`

trunk/source/lisp-kernel/x86-spentry64.s

@@ -3692 +3692 @@
         __(cmpb %imm0_b,%imm1_b)
         __(jne 2f)
-        __(extract_subtag(%arg_y,%imm0_b))
-        __(extract_subtag(%arg_z,%imm1_b))
+        __(extract_subtag(%arg_y,%imm0))
+        __(extract_subtag(%arg_z,%imm1))
         __(cmpb %imm0_b,%imm1_b)
         __(jne 2f)
@@ -3709 +3709 @@
         __(cmpb $tag_misc,%imm0_b)
         __(jnz 8f)
-        __(extract_subtag(%arg_z,%imm0_b))
+        __(extract_subtag(%arg_z,%imm0))
         __(rcmpb(%imm0_b,$min_vector_subtag))
         __(jb 8f)
@@ -4751 +4751 @@
 6:      __(addq arrayH.displacement(%arg_y),%arg_z)
         __(movq arrayH.data_vector(%arg_y),%arg_y)
-        __(extract_subtag(%arg_y,%imm1_b))
-        __(cmpb $subtag_vectorH,%imm1_b)
+        __(extract_subtag(%arg_y,%imm1))
+        __(cmpb $subtag_vectorH,%imm1_b) 
         __(ja C(misc_ref_common))
         __(jmp 6b)
@@ -4794 +4794 @@
 8:      __(addq arrayH.displacement(%arg_y),%arg_z)
         __(movq arrayH.data_vector(%arg_y),%arg_y)
-        __(extract_subtag(%arg_y,%imm1_b))
+        __(extract_subtag(%arg_y,%imm1))
         __(cmpb $subtag_vectorH,%imm1_b)
         __(ja C(misc_ref_common))
@@ -4830 +4830 @@
 6:      __(addq arrayH.displacement(%arg_x),%arg_y)
         __(movq arrayH.data_vector(%arg_x),%arg_x)
-        __(extract_subtag(%arg_x,%imm1_b))
+        __(extract_subtag(%arg_x,%imm1))
         __(cmpb $subtag_vectorH,%imm1_b)
         __(ja C(misc_set_common))
@@ -4873 +4873 @@
 8:      __(addq arrayH.displacement(%arg_x),%arg_y)
         __(movq arrayH.data_vector(%arg_x),%arg_x)
-        __(extract_subtag(%arg_x,%imm1_b))
+        __(extract_subtag(%arg_x,%imm1))
         __(cmpb $subtag_vectorH,%imm1_b)
         __(ja C(misc_set_common))