Changeset 14559

Timestamp:

Jan 6, 2011, 4:55:02 PM (14 years ago)

Author:

Gary Byers

Message:

In LDB compiler macro, just do a LOGAND if the bytespec's position
is 0.

Fixes ticket:805.

File:

• trunk/source/compiler/optimizers.lisp (modified) (1 diff)

trunk/source/compiler/optimizers.lisp

@@ -584 +584 @@
 
 (define-compiler-macro ldb (&whole call &environment env byte integer)
-   (cond ((and (integerp byte) (> byte 0))
-          (let ((size (byte-size byte))
-                (position (byte-position byte)))
-            (cond ((nx-form-typep integer 'fixnum env)
-                   `(logand ,(byte-mask size)
-                     (the fixnum (ash ,integer ,(- position)))))
-                  (t `(load-byte ,size ,position ,integer)))))
-         ((and (consp byte)
-               (eq (%car byte) 'byte)
-               (eq (list-length (%cdr byte)) 2))
-          (let ((size (%cadr byte))
-                (position (%caddr byte)))
-            (if (and (nx-form-typep integer 'fixnum env) (fixnump position))
-              ;; I'm not sure this is worth doing
-              `(logand (byte-mask ,size) (the fixnum (ash ,integer ,(- position))))
-              ;; this IS worth doing
-              `(load-byte ,size ,position ,integer))))
-         (t call)))
+  (cond ((and (integerp byte) (> byte 0))
+         (let ((size (byte-size byte))
+               (position (byte-position byte)))
+           (cond ((nx-form-typep integer 'fixnum env)
+                  `(logand ,(byte-mask size)
+                    (the fixnum (ash ,integer ,(- position)))))
+                 ((zerop position)
+                  `(logand ,(byte-mask size) ,integer))
+                 (t `(load-byte ,size ,position ,integer)))))
+        ((and (consp byte)
+              (eq (%car byte) 'byte)
+              (eq (list-length (%cdr byte)) 2))
+         (let ((size (%cadr byte))
+               (position (%caddr byte)))
+           (if (eql position 0)
+             `(logand (byte-mask ,size) ,integer)
+             (if (and (nx-form-typep integer 'fixnum env) (fixnump position))
+               ;; I'm not sure this is worth doing
+               `(logand (byte-mask ,size) (the fixnum (ash ,integer ,(- position))))
+               ;; this IS worth doing
+               `(load-byte ,size ,position ,integer)))))
+        (t call)))
 
 (define-compiler-macro length (&whole call &environment env seq)