Changeset 14486

Timestamp:

Dec 15, 2010, 5:41:51 PM (10 years ago)

Author:

rme

Message:

Merge r14482 from trunk: x86 spjump table doesn't need to be executable.

See ​https://bugzilla.redhat.com/show_bug.cgi?id=562226#c17 for the
issue this is meant to address.

Location:

release/1.6/source

Files:

• . (modified) (1 prop)
• lisp-kernel/pmcl-kernel.c (modified) (2 diffs)

release/1.6/source/lisp-kernel/pmcl-kernel.c

@@ -1417 +1417 @@
     if (!VirtualProtect((pc) SPJUMP_TARGET_ADDRESS,
                         0x1000,
-                        PAGE_EXECUTE_READWRITE,
+                        PAGE_READWRITE,
                         &old_protect)) {
       wperror("VirtualProtect spjump");
@@ -1432 +1432 @@
   pc new = mmap((pc) SPJUMP_TARGET_ADDRESS,
                 0x1000,
-                PROT_READ | PROT_WRITE | PROT_EXEC,
+                PROT_READ | PROT_WRITE,
                 MAP_PRIVATE | MAP_ANON | MAP_FIXED,
                 -1,