Changeset 14481

Timestamp:

Dec 11, 2010, 9:27:28 AM (10 years ago)

Author:

gb

Message:

Pasting clipboard content from other applications doesn't work under
Cocotron, because of confusion about the format and endianness of that
data. (What actually gets pasted is a string with byte-reversed character
codes, which may not be visible even though it make take up space in the
buffer.)

Try to work around that: if more than half of the (16-bit) characters
in the string obtained from the clipboard have 0s in their low bytes,
assume that the string is byte-reversed 8-bit text and reverse those
characters again. This can be fooled, so this workaround should be
removed when the underlying Cocotron bug is fixed.

For the sake of argument, this fixes ticket:740, though we should
report the underlying Cocotron confusion and try to render the workaround
unnecessary.

File:

• trunk/source/cocoa-ide/cocoa-editor.lisp (modified) (2 diffs)

trunk/source/cocoa-ide/cocoa-editor.lisp

@@ -3368 +3368 @@
      *nsapp* (@selector #/stringToPasteBoard:) (%make-nsstring string) t)))
 
+#+cocotron
+;;; Work around a byte-order bug that affects #/paste.
+(defun maybe-byte-reverse-string (nsstring)
+  (let* ((len (#/length nsstring))
+         (maybe-reversed-count  0))
+    (dotimes (i len)
+      (when (not (logtest #xff (#/characterAtIndex: nsstring i)))
+        (incf maybe-reversed-count)))
+    (if (> maybe-reversed-count (ash len -1))
+      (%stack-block ((chars (* 2 len)))
+        (ns:with-ns-range (r 0 len)
+          (#/getCharacters:range: nsstring chars r)
+          (dotimes (i len)
+            (declare (fixnum i))
+            (let* ((j (+ i i)))
+              (declare (fixnum j))
+              (let* ((w (%get-unsigned-word chars j)))
+                (setf (%get-unsigned-word chars j)
+                      (dpb (ldb (byte 8 0) w)
+                           (byte 8 8)
+                           (ldb (byte 8 8) w))))))
+
+            
+          (#/autorelease
+           (make-instance ns:ns-string
+                          :with-characters chars
+                          :length len))))
+      nsstring)))
+                        
+                    
+                                                            
 ;;; The default #/paste method seems to want to set the font to
 ;;; something ... inappropriate.  If we can figure out why it
@@ -3383 +3414 @@
     #+debug (log-debug "   string = ~s" string)
     (unless (%null-ptr-p string)
+      #+cocotron (setq string (maybe-byte-reverse-string string))
       (unless (zerop (ns:ns-range-length (#/rangeOfString: string *ns-cr-string*)))
         (setq string (make-instance 'ns:ns-mutable-string :with-string string))