Changeset 14422

Timestamp:

Nov 9, 2010, 7:11:26 PM (14 years ago)

Author:

Gary Byers

Message:

When walking the managed_static_area's refbits (in
mark_managed_static_refs() and forward_memoized_area(), don't read the
next word from the bitvector if we're at the end. (If the bitvector
ends on a page boundary, the page following the bitvector may be
unmapped.)

(This fencepost has always been there in mark_memoized_area(), but the
word following the end of the traditional intergenerational references
map is always mapped in that case - it's part of the dynamic area's
markbits vector.)

File:

• trunk/source/lisp-kernel/gc-common.c (modified) (2 diffs)

trunk/source/lisp-kernel/gc-common.c

@@ -1138 +1138 @@
         memo_dnode += remain;
         p += (remain+remain);
-        bits = *++bitsp;
+        if (memo_dnode < num_memo_dnodes) {
+          bits = *++bitsp;
+        }
         bitidx = 0;
       } else {
@@ -1338 +1340 @@
           *bitsp = outbits;
         }
-        bits = *++bitsp;
+        if (memo_dnode < num_memo_dnodes) {
+          bits = *++bitsp;
+        }
         inbits = outbits = bits;
         bitidx = 0;