Changeset 14233

Timestamp:

Sep 6, 2010, 7:37:28 PM (14 years ago)

Author:

Gary Byers

Message:

Don't use the (Linux-specific ?) MAP_GROWSDOWN mmap option when allocating
stacks; it doesn't do what we thought it did and using it seems to trigger
a bug in some 2.6.32 Linux kernels. See ticket:731, which this change might
fix.

Location:

trunk/source/lisp-kernel

Files:

• memory.c (modified) (1 diff)
• memprotect.h (modified) (1 diff)
• thread_manager.c (modified) (1 diff)

trunk/source/lisp-kernel/memory.c

@@ -298 +298 @@
   return VirtualAlloc(0, nbytes, MEM_RESERVE|MEM_COMMIT, MEMPROTECT_RWX);
 #else
-  return mmap(NULL, nbytes, MEMPROTECT_RWX, MAP_PRIVATE|MAP_ANON|MAP_GROWSDOWN, -1, 0);
+  return mmap(NULL, nbytes, MEMPROTECT_RWX, MAP_PRIVATE|MAP_ANON, -1, 0);
 #endif
 }

trunk/source/lisp-kernel/memprotect.h

@@ -46 +46 @@
 #define MEMPROTECT_RX   (PROT_READ|PROT_EXEC)
 #define MEMPROTECT_RWX  (PROT_READ|PROT_WRITE|PROT_EXEC)
-#ifndef MAP_GROWSDOWN
-#define MAP_GROWSDOWN (0)
-#endif
 
 

trunk/source/lisp-kernel/thread_manager.c

@@ -1598 +1598 @@
   
   
-#ifndef MAP_GROWSDOWN
-#define MAP_GROWSDOWN 0
-#endif
 
 Ptr