Changeset 13925

Timestamp:

Jul 5, 2010, 6:32:56 PM (14 years ago)

Author:

Gary Byers

Message:

arm-asmutils.s: don't use magic Linux kernel function for store_condtional,
just use ldrex/strex.
arm-constants.s: byte order in definitions of bytes_consed_[high,low] slots
in TCR.
arm-exceptions.s: in normalize_tcr(), if other_tcr is in ff-call, need to
update the cs_area based on tcr->last_lisp_frame.
arm-gc.c: check for running off end of cstack in mark_cstack_area().

Location:

branches/arm/lisp-kernel

Files:

• arm-asmutils.s (modified) (1 diff)
• arm-constants.s (modified) (1 diff)
• arm-gc.c (modified) (1 diff)

branches/arm/lisp-kernel/arm-asmutils.s

@@ -64 +64 @@
 
 _exportfn(C(store_conditional))
-        __ifdef([LINUX])
-        /* To deal with different ARM variants, Linux provides
-           a magic kernel function that does the right thing in
-           the absence of ldrex/strex/clrex and memory-barrier
-           functions.  That function takes args in a different
-           order (r0 = expected oldval, r1 = newval, r2 = addr.)
-        */
-        __(stmdb pc!,{r4,lr})
-        __(eor r0,r0,r2)
-        __(eor r2,r2,r0)
-        __(eor r0,r0,r2)
-0:      __(ldr r3,[r2])
-        __(cmp r3,r0)
-        __(bne 1f)   
-        __(mov lr,#0xffff0fff)
-        __(add lr,lr,#(0xffff0fc0 - 0xffff0fff))
-        __(blx lr)
-        __(bcc 0b)
-1:      __(mov r0,r3)
-        __(ldmia pc!,{r4,lr})
-        __endif
+0:      __(ldrex r3,[r0])
+        __(cmp r3,r1)
+        __(bne 1f)
+        __(strex ip,r2,[r0])
+        __(cmp ip,#0)
+        __(bne 0b)
+        __(b 2f)
+1:      __(clrex)
+2:      __(mov r0,r3)
+        __(bx lr)                
 _endfn
 

branches/arm/lisp-kernel/arm-constants.s

@@ -597 +597 @@
          _node(last_lisp_frame) /* when in foreign code */
          _node(cs_limit)        /* cstack overflow limit */
+         _node(bytes_consed_low)
          _node(bytes_consed_high)
-         _node(bytes_consed_low)
          _node(log2_allocation_quantum)
          _node(interrupt_pending)

branches/arm/lisp-kernel/arm-gc.c

@@ -991 +991 @@
       Bug(NULL, "Unknown stack word at 0x" LISP ":\n", current);
     }
+  }
+  if (current != limit) {
+    Bug(NULL, "Ran off the end of cstack area\n");
   }
 }