Changeset 12908

Timestamp:

Oct 5, 2009, 3:25:39 AM (11 years ago)

Author:

rme

Message:

In unwatch_object(): if some other thread is waiting to handle an
exception, don't unwatch the object and arrange for UNWATCH to return
NIL.

safe_to_unwatch(): new function.

File:

• branches/watchpoints/lisp-kernel/x86-exceptions.c (modified) (2 diffs)

branches/watchpoints/lisp-kernel/x86-exceptions.c

@@ -3747 +3747 @@
 }
 
+/* If some other thread is waiting to handle an exception, it may
+   not be safe to unwatch the object. */
+int
+safe_to_unwatch(TCR *tcr)
+{
+  TCR *other;
+
+  for (other = tcr->next; other != tcr; other = other->next) {
+    if (other->xframe) {
+      return false;
+    }
+  }
+  return true;
+}
+
+
 /*
  * We expect the watched object in arg_y, and the new uninitialized
@@ -3761 +3777 @@
   LispObj *newnode = (LispObj *)untag(new);
   area *a = area_containing((BytePtr)old);
+
+  if (safe_to_unwatch(tcr) == false) {
+    xpGPR(xp, Iarg_z) = lisp_nil;
+    return 0;
+  }
 
   if (a && a->code == AREA_WATCHED) {