Changeset 12878

Timestamp:

Sep 22, 2009, 9:11:13 PM (10 years ago)

Author:

gz

Message:

Bring back Edit Command Definition and make it work.

This fixes bug #168

File:

• trunk/source/cocoa-ide/hemlock/src/edit-defs.lisp (modified) (2 diffs)

trunk/source/cocoa-ide/hemlock/src/edit-defs.lisp

@@ -93 +93 @@
         (error (c) (editor-error (format nil "~a" c)))))))
       
-
-#|
-;;; "Edit Command Definition" is a hack due to creeping evolution in
-;;; GO-TO-DEFINITION.  We specify :function type and a name with "-COMMAND"
-;;; instead of :command type and the real command name because this causes
-;;; the right pattern to be created for searching.  We could either specify
-;;; that you always edit command definitions with this command (breaking
-;;; "Go to Definition" for commands called as functions), fixing the code,
-;;; or we can hack this command so everything works.
-;;;
 (defcommand "Edit Command Definition" (p)
-  "Prompts for command definition name and goes to it for editing."
   "Prompts for command definition name and goes to it for editing."
   (multiple-value-bind
@@ -116 +105 @@
         (prompt-for-keyword :tables (list *command-names*)
                             :prompt "Command to edit: "))
-    (go-to-definition (fun-defined-from-pathname (command-function command))
-                      :function
-                      (concatenate 'simple-string name "-COMMAND"))))
-
+    (declare (ignore name))
+    (handler-case (edit-definition (command-function command))
+      (error (c) (editor-error (format nil "~a" c))))))
+
+#|
 ;;; FUN-DEFINED-FROM-PATHNAME takes a symbol or function object.  It
 ;;; returns a pathname for the file the function was defined in.  If it was