Ticket #227 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Hemlock shouldn't crash CCL if it runs into an attribute line it doesn't understand

Reported by: alms Owned by: gz
Priority: major Milestone:
Component: IDE Version:
Keywords: hemlock Cc:

Description

(From GB e-mail response to Ron Garret)

All that I can tell is that it's trying to write a warning to the echo area to the effect that it doesn't understand the "Syntax:" file option; I'm not sure that the echo area even exists at this point. (It's dying in the method #/readFromURL:ofType:error: on hemlock-editor-document; this code is running on the event thread, and whatever its notion of "the echo area" is, it probably isn't correct.)

If it's going to try to parse the attribute line and if it's going to do someting other than silently ignore attributes that it doesn't understand, it should probably do that parsing a little later (and, in the current model, it should do that on the right thread.)

On Thu, 3 Jan 2008, Ron Garret wrote:

Correction: It's (apparently) not CFFI. The problem seems to be trying to open a file containing the following modeline:

;;; -*- Mode: LISP; Syntax: ANSI-Common-Lisp; Package: CL-USER; -*-

Trying to open a file with this modeline dumps a whole bunch of error messages to the console and results in a broken Lisp.

Change History

comment:1 Changed 6 years ago by gz

  • Status changed from new to assigned

FWIW this is fixed in the 'event-ide' branch, and which should get migrated into the trunk in a few weeks.

comment:2 Changed 6 years ago by gz

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in r8428

Note: See TracTickets for help on using tickets.