Ticket #216 (closed enhancement: fixed)

Opened 6 years ago

Last modified 4 years ago

Provide keyword arguments to process-run-function pipe streams

Reported by: danieldickison Owned by: gb
Priority: major Milestone: Clozure CL 1.4
Component: Compiler Version:
Keywords: stream process thread locking Cc:

Description

Given the new features for streams, namely the :sharing and :external-format improvements, it would be nice to be able to specify these keyword arguments for streams when doing something like:

(process-run-function "foo" #'foo :input :stream :output :stream)

I think having new keyword parameters like :input-args etc. would be better than adding a new keyword for each parameter (i.e. :input-sharing, :input-external-format, etc). Does this seem like a reasonable solution? (If so I can try to put a patch together to do this).

Alternatively, if a pipe stream creation API was exported (with support for these keyword options), then it would make it possible to create the pipe streams first, and simply pass them into process-run-function.

Attachments

run-program-sharing.diff Download (2.8 KB) - added by danieldickison 6 years ago.
Patch to add a single :sharing argument to run-program

Change History

Changed 6 years ago by danieldickison

Patch to add a single :sharing argument to run-program

comment:1 Changed 5 years ago by danieldickison

Just wanted to note that r11440 seems to incorporate the attached patch for :sharing. If using a single keyword for all 3 streams (in, out, error) is deemed sufficient, maybe doing the same for :external-format will be OK too (it's OK for my needs; I'm not sure if there are other use cases where you want different :sharing or :external-formats for in/out/error).

comment:2 Changed 5 years ago by rme

  • Milestone set to Clozure CL 1.4

comment:3 Changed 4 years ago by rme

  • Status changed from new to closed
  • Resolution set to fixed

:external-format added in r13108

Note: See TracTickets for help on using tickets.